Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this._resetSubControllers is not a function #449

Closed
vvscode opened this issue Aug 10, 2015 · 7 comments
Closed

this._resetSubControllers is not a function #449

vvscode opened this issue Aug 10, 2015 · 7 comments

Comments

@vvscode
Copy link
Contributor

vvscode commented Aug 10, 2015

I've got this error on transition from one route to another. But it's happens only if I refresh page with active tab with Ember-debugger. After that - every time after page reload I've got this error on the same transition. To fix - I should close Developer tools, refresh page and then open DevTools again

Stack is

__exports__.default.ArrayProxy.extend.willDestroy   @   ember.js:29004
apply   @   ember.js:19663
superWrapper    @   ember.js:19235
willDestroy @   VM26681:2298
Queue.invoke    @   ember.js:848
Queue.flush @   ember.js:913
DeferredActionQueues.flush  @   ember.js:718
Backburner.end  @   ember.js:143
Backburner.run  @   ember.js:198
run @   ember.js:17905
(anonymous function)    @   socket-adapter.js:163
EventEmitter.emit   @   socket.io.js:623
SocketNamespace.onPacket    @   socket.io.js:2190
Socket.onPacket @   socket.io.js:1882
Transport.onPacket  @   socket.io.js:1311
Transport.onData    @   socket.io.js:1282
WS.open.websocket.onmessage @   socket.io.js:2329

at >> willDestroy @ VM26681:2298 is
return _oldWillDestroy.apply(_this2, _arguments);
from code


    retainObject: function retainObject(object) {
      var _this2 = this,
          _arguments = arguments;

      var meta = emberMeta(object);
      var guid = guidFor(object);

      meta._debugReferences = meta._debugReferences || 0;
      meta._debugReferences++;

      this.sentObjects[guid] = object;

      if (meta._debugReferences === 1 && object.reopen) {
        (function () {
          // drop object on destruction
          var _oldWillDestroy = object._oldWillDestroy = object.willDestroy;
          object.reopen({
            willDestroy: function willDestroy() {
              _this2.dropObject(guid);
              return _oldWillDestroy.apply(_this2, _arguments);
            }
          });
        })();
      }

      return guid;
    },

_oldWillDestroy is Ember.K ( function K() { return this; } )

_this2 is

Class {
namespace: Class, 
sentObjects: Object, 
boundObservers: Object, 
__ember1439224455762: null, 
__ember_meta__: Object
}
"<(unknown mixin):ember3886>"

I'm not sure that this bug is critical but it is confused

@teddyzeenny
Copy link
Contributor

Thanks for reporting this. Definitely a regression.

@vvscode
Copy link
Contributor Author

vvscode commented Aug 20, 2015

Please describe what do I need to do to fix this one for me?

@shahroon
Copy link

@teddyzeenny how to fix this?

Do I need to replace these lines

  •    willDestroy: () => {
    
  •      this.dropObject(guid);
    

with these,

  •    willDestroy() {
    
  •      self.dropObject(guid);
    

or to pull something? or what?

@teddyzeenny
Copy link
Contributor

This has been fixed but I haven't been able to release on Chrome yet due to a bug in the Chrome Web Store.

In the meantime you can:

@shahroon
Copy link

Yea, already started to use FF.

Thanks

@teddyzeenny
Copy link
Contributor

FYI the new version has been released on Chrome too.

@shahroon
Copy link

shahroon commented Sep 1, 2015

Perfect. (Y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants