Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full angle bracket name should be searchable #1059

Closed
ghost opened this issue Nov 7, 2019 · 6 comments
Closed

full angle bracket name should be searchable #1059

ghost opened this issue Nov 7, 2019 · 6 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Nov 7, 2019

Issue and Steps to Reproduce

This is a nuance to #1021. I expect to be able to search by the full component name, not just he first segment.

  • Navigate to https://tv.apple.com/
  • Open ember inspector
  • go to the "Components" tab and type nav. You should see the <NavHeader/> result
  • type navh and you should see no results

Your environment

stable chrome, latest ember inspector

Screenshots

expected

expected_Screen Shot 2019-11-07 at 08 52 22

unexpected

unexpected_Screen Shot 2019-11-07 at 08 54 11

I'd guess we are not correctly normalizing the entire component name for the case insensitive search. Hopefully it is a simple fix.

@RobbieTheWagner
Copy link
Member

I'd guess we are not correctly normalizing the entire component name for the case insensitive search. Hopefully it is a simple fix.

Definitely sounds like that is the issue. @nummi mind taking a look?

@nummi
Copy link
Collaborator

nummi commented Nov 7, 2019

Yeah, I’ll take a look today. This should be a quick one.

@nummi
Copy link
Collaborator

nummi commented Nov 7, 2019

@rwwagner90, I think we should do a deploy. My fix for this (#1021) is only on master.

@RobbieTheWagner
Copy link
Member

Ah gotcha. I will get a deploy out

@chancancode
Copy link
Member

Can you test this on the latest (3.12.2) version?

@RobbieTheWagner
Copy link
Member

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants