Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildBabelOptions returns some things that aren't valid babel options #227

Closed
ef4 opened this issue Jun 11, 2018 · 5 comments
Closed

buildBabelOptions returns some things that aren't valid babel options #227

ef4 opened this issue Jun 11, 2018 · 5 comments

Comments

@ef4
Copy link
Collaborator

ef4 commented Jun 11, 2018

annotation and throwUnlessParallelizable are returned by buildBabelOptions(), but they aren't really babel options, they're broccoli-babel-transpiler options.

This came up because in ember-auto-import I'm trying to automatically configure a babel parser based off the app's babel configuration.

I think these options should be kept separate from the real babel options.

@ef4
Copy link
Collaborator Author

ef4 commented Jun 11, 2018

Just hit another example, which is the weird not-really-a-plugin entry with _parallelBabel that we put into the plugins list.

@rwjblue
Copy link
Member

rwjblue commented Sep 18, 2020

@ef4 Think we should avoid adding them and make a private internal API for when we have to talk to broccoli-babel-transpiler?

@ef4
Copy link
Collaborator Author

ef4 commented Sep 18, 2020

Or at least keep them together under a single property within the Babel config, so it’s easier to split them back out.

@rwjblue
Copy link
Member

rwjblue commented Dec 11, 2020

FWIW, this will be resolvable with #371.

@lifeart
Copy link

lifeart commented Mar 4, 2021

may be related embroider-build/ember-auto-import#267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants