Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types do not resolve in 3.11.0 #6217

Closed
dustinsoftware opened this issue Jul 2, 2019 · 4 comments
Closed

Types do not resolve in 3.11.0 #6217

dustinsoftware opened this issue Jul 2, 2019 · 4 comments
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@dustinsoftware
Copy link

dustinsoftware commented Jul 2, 2019

Reproduction

  1. Clone https://github.com/dustinsoftware/ember-data-issue-repro/
  2. ember build
  3. Observe type error resolving DS.Store

Description

Types are not resolving in [email protected] with the types provided in @types/ember-data. I suspect an empty type definition is being shipped that is causing Typescript to ignore the types from DefinitelyTyped. cc @mike-north

image

Versions

Run the following command and paste the output below: npm ls ember-source && npm ls ember-cli && npm ls ember-data.

[email protected] C:\code\e-data-ts
`-- [email protected]

[email protected] C:\code\e-data-ts
`-- [email protected]

[email protected] C:\code\e-data-ts
`-- [email protected]

P.S. If any of the packages show more than one installed version, that may be the root cause of the issue!


Thanks again!

The ember-data Team <3

@richard-viney
Copy link

As mentioned on Discord, I've worked around this issue by adding the following to package.json:

  "scripts": {
    "postinstall": "rm -f node_modules/ember-data/stripped-types.d.ts"
  }

@mike-north
Copy link
Contributor

@runspired looks like this mechanism is no longer going to work for us. We should switch to stripping all .d.ts files from packages in a prepublish step

@rwjblue rwjblue added the Bug label Jul 8, 2019
@dustinsoftware
Copy link
Author

Fixed in #6256

@runspired
Copy link
Contributor

Ah yes, thanks @dustinsoftware forgot to close :)

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

No branches or pull requests

5 participants