New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build broken with Ember Canary #5962

Closed

igorT opened this issue Apr 4, 2019 · 4 comments

Member

igorT commented Apr 4, 2019

https://travis-ci.org/emberjs/data/jobs/515668214

Member Author

igorT commented Apr 4, 2019

It seems to be caused by our test suite calling deprecated methods, uncovered by emberjs/ember.js#17845

Member Author

igorT commented Apr 4, 2019

Three sources of errors are:

Testing calling new against a model which we can remove
Instantiating Transforms in tests with new
A random test using removaAll listeners, which needs to be refactored

Member Author

igorT commented Apr 4, 2019

Contributor

runspired commented Apr 4, 2019

[FIX transforms] don't instantiate via new [FIX transforms] don't instantiate via new #5963
[FIX ManyArray] Evented.off requires a reference to the original callback [FIX ManyArray] Evented.off requires a reference to the original callback #5964
[FIX model] assertions around create need to account for Ember's own [FIX model] assertions around create need to account for Ember's own #5965

igorT closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment