Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.assign is not supported in IE11 #5550

Closed
hmajoros opened this issue Jul 31, 2018 · 2 comments
Closed

Object.assign is not supported in IE11 #5550

hmajoros opened this issue Jul 31, 2018 · 2 comments

Comments

@hmajoros
Copy link

Exact Line of Code:

Object.assign(createOptions, additionalCreateOptions);

This problem typically can be solved by using the Ember built in polyfill for Object.assign: Ember.assign:

import { assign } from '@ember/polyfills';
...

assign(createOptions, additionalCreateOptions);

Reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign

@rwjblue
Copy link
Member

rwjblue commented Jul 31, 2018

IMHO, we should fix this via babel.

Specifically:

  • Add babel-plugin-transform-object-assign
  • Add something like this to ensure that Ember.assign is used as the provided helper.

@rwjblue
Copy link
Member

rwjblue commented Jul 31, 2018

Looks like this was fixed in #5549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants