Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultValue doesn't work in latest beta #5493

Closed
Sinled opened this issue Jun 15, 2018 · 6 comments
Closed

defaultValue doesn't work in latest beta #5493

Sinled opened this issue Jun 15, 2018 · 6 comments

Comments

@Sinled
Copy link

Sinled commented Jun 15, 2018

After i've updated ember data to 3.2.0-beta.4, some of my tests, that were depending on defaultValue failed.

I have made a new repo with reproduction
model
test
ember-try settings

these tests work fine with ember data 3.1.1

Am i doing something wrong?

@nickschot
Copy link

I think this was fixed in #5428 which seems to not have been included in this beta :( .

@urbany
Copy link

urbany commented Jun 18, 2018

Yeah unfortunately the latest beta is missing that, and the latest release has other bugs, so right now I'm using this in production: "ember-data": "github:emberjs/data#c438a8a5e053724eb5b5257a451259a761a06d98"

This commit has the defaultValue fix and I didn't notice any bugs. Have been running it in production for a few weeks now.

I know the devs do this on their free time and really appreciate their hard work, but it would be pretty cool if someone could release a new beta with that fix. Thanks in advance :)

@rwjblue
Copy link
Member

rwjblue commented Jun 18, 2018

I'm trying to set up the final release of 3.2 today, and am under a bit of a crunch from other obligations, but if you have the time you can cherry-pick the change and send a PR targeting the beta branch. I'll sit down with @runspired (and possibly @hjdivad) to review to make sure it is low enough risk to land into the beta branch...

@lhoBas
Copy link

lhoBas commented Jun 18, 2018

@rwjblue I've gone ahead and created the cherry-pick PR. Hope this will make the cut, it's a 'make-it-or-break-it' for us with 3.2 😅

@rwjblue rwjblue closed this as completed Jun 19, 2018
@rwjblue
Copy link
Member

rwjblue commented Jun 19, 2018

Thank you!

@BnitoBzh
Copy link

There is no 3.2.0-beta-5 version scheduled with the #5497 ?
The only solution is to use [email protected] + ember-data@beta ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants