-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defaultValue doesn't work in latest beta #5493
Comments
I think this was fixed in #5428 which seems to not have been included in this beta :( . |
Yeah unfortunately the latest beta is missing that, and the latest release has other bugs, so right now I'm using this in production: "ember-data": "github:emberjs/data#c438a8a5e053724eb5b5257a451259a761a06d98" This commit has the defaultValue fix and I didn't notice any bugs. Have been running it in production for a few weeks now. I know the devs do this on their free time and really appreciate their hard work, but it would be pretty cool if someone could release a new beta with that fix. Thanks in advance :) |
I'm trying to set up the final release of 3.2 today, and am under a bit of a crunch from other obligations, but if you have the time you can cherry-pick the change and send a PR targeting the beta branch. I'll sit down with @runspired (and possibly @hjdivad) to review to make sure it is low enough risk to land into the beta branch... |
@rwjblue I've gone ahead and created the cherry-pick PR. Hope this will make the cut, it's a 'make-it-or-break-it' for us with 3.2 😅 |
Thank you! |
There is no 3.2.0-beta-5 version scheduled with the #5497 ? |
After i've updated ember data to
3.2.0-beta.4
, some of my tests, that were depending ondefaultValue
failed.I have made a new repo with reproduction
model
test
ember-try settings
these tests work fine with ember data 3.1.1
Am i doing something wrong?
The text was updated successfully, but these errors were encountered: