Store push / findRecord causes model to reload previously destroyed record

[locks]

Original: emberjs/ember.js#14895

This is a bit complex to describe with out showing, but I do believe it is a bug.

I have a model, feed, which hasMany feedTracks.

When a user takes a certain action, the top object in the feedTracks array is removed. But then, when I go to insert a new object into that array, the old object that was just removed, reappears.

    skipFeedTrack(feedTrack) {
      feedTrack.skip().then((response) => {
        feedTrack.destroyRecord().then(() => {
          this.modelFor('master.feed').get('feedTracks').removeObject(feedTrack);
        });
        if (response != null) {
          this.store.pushPayload({feedTrack: response});
        }
      }.bind(this));
    }

The feedTrack is successfully removed from the feedTracks array (which is a hasMany relationship to the feed). But then, when this.store.pushPayload({feedTrack: response}); or any variation of that (i.e. findRecord, or push) is called, the feedTrack that was just removed reappears on the template at the top.

I believe this is a bug as, when you call destroy() on a record, it should effectively remove it from the cache.

Ultimately at the end of the day, all I want to do is remove one record/object from the hasMany association and insert another which is given from the server response to the call to skip().

— @gregattra

[runspired]

Fixed by #4791 and #4792 with a failing test committed by #4790

[bmac]

This is fixed by #4791 and the fix was published in the Ember Data 2.11.1 release. I'm going to close this issue now but please let me know if you are still experiencing a problem.

[gbattra]

Fix resolved this issue for me. Thank you for getting this out quickly.

[joshsmith]

🙌