Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove relationship guard in relationship/state/relationship.js destroy #4755

Closed
hjdivad opened this issue Jan 16, 2017 · 0 comments
Closed

Comments

@hjdivad
Copy link
Member

hjdivad commented Jan 16, 2017

This guard exists solely to help with bad state during test teardown. The issue is that relationships can wind up in a bad state. Remove the assertion and then clean up things that cause this kind of bad state.

One known example is that the type check for pushing onto a has many happens too late: in particular it happens after members has already been mutated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant