Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS.Store.findAll adapterOptions v2.2 #4329

Closed
goofiw opened this issue Apr 13, 2016 · 3 comments
Closed

DS.Store.findAll adapterOptions v2.2 #4329

goofiw opened this issue Apr 13, 2016 · 3 comments

Comments

@goofiw
Copy link

goofiw commented Apr 13, 2016

in order to pass adapter options, I have to pass an object with the name adapterOptions.
i.e.

this.store.findall('my-model', {adapterOptions: {waka: 'waka'}}

from the api it looks like I should be able to just pass {waka: 'waka'}

@wecc
Copy link
Contributor

wecc commented Apr 14, 2016

The second argument to store.findAll() is options. adapterOptions is one available option and needs to be wrapped.

Do you have an example of where in the API it looks like you should be able to just pass the adapterOptions without wrapping them? We should definitely improve the docs if this is unclear.

@pangratz
Copy link
Member

@goofiw just in case you are asking on why it is needed to pass all the options for the adapter into adapterOptions: { ... }: the options for the adapter need to be placed into adapterOptions because not all properties in the passed hash are intended for the adapter. By specifying store.findAll('my-model', { reload: true }) for example, you can tell ember data the specific reload behavior. The reload option shouldn't be passed to the adapter...

@bmac
Copy link
Member

bmac commented May 26, 2016

I believe this is closed by #4405 where the documentation for adapterOptions has been updated.

@bmac bmac closed this as completed May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants