ember-cli-shim check errors if no shim is provided

[stefanpenner]

this prevents us from bundling shims with the future ember module.

I suspect something like this.project.findAddonByName('ember-source') will be a sufficient check

[rwjblue]

Removing the existing checks would cause extra pain to users upgrading and having the wrong versions, but we can definitely make it work properly when ember-cli-shims is not present in bower.json.

Also, we can't use findAddonByName because it isn't an addon.

[stefanpenner]

@rwjblue i think you misread, if that addon is present no shims for ember are required. Otherwise it should do the existing flow.

[rwjblue]

[email protected] provided shims for both Ember Data and Ember. If [email protected] is present with ember-data@^2.3.0 we need to provide an accurate message telling them to change what they are including.

[rwjblue]

I agree that the presence of ember-source changes things a bit (because once that happens ember-cli-shims is not needed anymore), but the real issue is that when ember-cli-shims is not present in bower.json at all we throw an error.

[rwjblue]

I submitted #4200 to address, can you review?

[rwjblue]

Also, FWIW, you are correct. I misread initially and thought you were suggesting to use project.findAddonByName('ember-cli-shims'). Sorry about that...

[stefanpenner]

I likely left the description too ambiguous