Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return empty included array when not sideloading records #3425

Closed
jcope2013 opened this issue Jun 23, 2015 · 1 comment
Closed

Do not return empty included array when not sideloading records #3425

jcope2013 opened this issue Jun 23, 2015 · 1 comment

Comments

@jcope2013
Copy link
Contributor

currently the default behavior is too return a blank included array inside the documentHash every time a record is saved

https://github.com/emberjs/data/blob/master/packages/ember-data/lib/serializers/rest-serializer.js#L243

this then gets pushed into the store as there is no length check so unneeded pushes are happening

https://github.com/emberjs/data/pull/3413/files

@fivetanley
Copy link
Member

fixed in #3413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants