Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether store.push/pushPayload should copy #3275

Closed
igorT opened this issue Jun 9, 2015 · 6 comments
Closed

Consider whether store.push/pushPayload should copy #3275

igorT opened this issue Jun 9, 2015 · 6 comments

Comments

@igorT
Copy link
Member

igorT commented Jun 9, 2015

No description provided.

@aldhsu
Copy link

aldhsu commented Jun 18, 2015

Not sure if this is a related issue. I think it would make sense if store.pushPayload returned the models pushed into the store.

At the moment on master link there is no return statement and store.pushPayload returns undefined.

screen shot 2015-06-18 at 5 02 27 pm

Contrast to store.push, link, where the model pushed in is returned.
screen shot 2015-06-18 at 5 03 14 pm

@wecc
Copy link
Contributor

wecc commented Oct 22, 2016

@aldhsu There's a feature named ds-pushpayload-return that enables pushPayload to return the result.

@pangratz
Copy link
Member

@aldhsu also see RFC #161

@aldhsu
Copy link

aldhsu commented Oct 24, 2016

@wecc @pangratz ok thanks!

@runspired
Copy link
Contributor

We could probably do this in dev for safety but seems like unnecessary work overall.

@runspired
Copy link
Contributor

as I've thought on this more, this is a Cache detail. Currently the cache does not retain this object (it copies, though by artifact and not design as it deconstructs resources into more granular caches) so it doesn't matter, if a Cache did retain this object it would likely want to deep-freeze it in dev as opposed to copying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants