Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta Issue] remove instance state from ModelFactories #2528

Closed
3 tasks
stefanpenner opened this issue Nov 27, 2014 · 2 comments
Closed
3 tasks

[Meta Issue] remove instance state from ModelFactories #2528

stefanpenner opened this issue Nov 27, 2014 · 2 comments
Labels
🏷️ bug This PR primarily fixes a reported issue
Milestone

Comments

@stefanpenner
Copy link
Member

specifically Model.store and anything else that pollutes.

this will let us fix:

  • typeKey
  • aspects of polymorphic
  • likely more.
@stefanpenner stefanpenner added this to the 1.0 milestone Nov 27, 2014
@stefanpenner stefanpenner changed the title Meta Issue tracking the removal of ModelFactory.store [Meta Issue] remove instance state from ModelFactories Nov 27, 2014
@sly7-7
Copy link
Contributor

sly7-7 commented Dec 14, 2014

@stefanpenner I tried to investigate where the store was needed in the factories, and I don't know what strategy we could use to remove it from the relationships descriptors like in https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/relationships/ext.js#L55, where the store is used to retrieve the type from relationship's meta.
I wish I could help on this one, but I need some insight to know where/how to start 😞

@igorT
Copy link
Member

igorT commented May 25, 2015

This is a dupe of a similar tracking bug, and is currently being handled by #3074

@igorT igorT closed this as completed May 25, 2015
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

No branches or pull requests

4 participants