Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Polymorphic relations don't serialize correctly #2385

Closed
aaronbhansen opened this issue Oct 14, 2014 · 2 comments · Fixed by #2623
Closed

Async Polymorphic relations don't serialize correctly #2385

aaronbhansen opened this issue Oct 14, 2014 · 2 comments · Fixed by #2623

Comments

@aaronbhansen
Copy link

If you have a belongsTo that is async and polymorphic, when it tries to serialize the model, it throws an error because it didn't unwrap the promise.

This can be seen here in the console assert. http://emberjs.jsbin.com/zisoba/8/edit

The quick solution locally was for me to unwrap it (https://gist.github.com/aaronbhansen/5a4bb73cf4c16b22b924), but that might be a good longterm fix.

@luketheobscure
Copy link
Contributor

Just ran into this myself. It seems like it should either be fixed, documented, or at least throw an error when you try to declare it as such.

I'm willing to fix this bug, but I would like guidance from one of the project maintainers on how they would like it fixed.

@igorT
Copy link
Member

igorT commented Jan 6, 2015

SHould be fixed by #2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants