Merge pull request #3329 from pangratz/remove_reduce_computed_from_model

Refactor `Errors#errorsByAttributeName` to not use Ember.reduceComputed
emberjs · Jun 14, 2015 · c093d72 · c093d72
2 parents 73cb924 + 71fecd2
commit c093d72
Showing 1 changed file with 9 additions and 20 deletions.
diff --git a/packages/ember-data/lib/system/model/errors.js b/packages/ember-data/lib/system/model/errors.js
@@ -109,26 +109,12 @@ export default Ember.Object.extend(Ember.Enumerable, Ember.Evented, {
     @type {Ember.MapWithDefault}
     @private
   */
-  errorsByAttributeName: Ember.reduceComputed("content", {
-    initialValue: function() {
-      return MapWithDefault.create({
-        defaultValue: function() {
-          return Ember.A();
-        }
-      });
-    },
-
-    addedItem: function(errors, error) {
-      errors.get(error.attribute).pushObject(error);
-
-      return errors;
-    },
-
-    removedItem: function(errors, error) {
-      errors.get(error.attribute).removeObject(error);
-
-      return errors;
-    }
+  errorsByAttributeName: Ember.computed(function() {
+    return MapWithDefault.create({
+      defaultValue: function() {
+        return Ember.A();
+      }
+    });
   }),
 
   /**
@@ -234,6 +220,7 @@ export default Ember.Object.extend(Ember.Enumerable, Ember.Evented, {
 
     messages = this._findOrCreateMessages(attribute, messages);
     get(this, 'content').addObjects(messages);
+    get(this, 'errorsByAttributeName').get(attribute).addObjects(messages);
 
     this.notifyPropertyChange(attribute);
     this.enumerableContentDidChange();
@@ -297,6 +284,7 @@ export default Ember.Object.extend(Ember.Enumerable, Ember.Evented, {
 
     var content = get(this, 'content').rejectBy('attribute', attribute);
     get(this, 'content').setObjects(content);
+    get(this, 'errorsByAttributeName').delete(attribute);
 
     this.notifyPropertyChange(attribute);
     this.enumerableContentDidChange();
@@ -331,6 +319,7 @@ export default Ember.Object.extend(Ember.Enumerable, Ember.Evented, {
     if (get(this, 'isEmpty')) { return; }
 
     get(this, 'content').clear();
+    get(this, 'errorsByAttributeName').clear();
     this.enumerableContentDidChange();
 
     this.trigger('becameValid');