Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter #345

Closed
pichfl opened this issue Jul 17, 2018 · 12 comments
Closed

[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter #345

pichfl opened this issue Jul 17, 2018 · 12 comments

Comments

@pichfl
Copy link

pichfl commented Jul 17, 2018

This happens when running ember-cli-template-lint in a project with ember-cli > 3.2.0.

[API] Warning: The .read and .rebuild APIs will stop working in the next Broccoli version
[API] Warning: Use broccoli-plugin instead: https://github.com/broccolijs/broccoli-plugin
[API] Warning: Plugin uses .read/.rebuild API: Filter
[API] Warning: Plugin uses .read/.rebuild API: Filter
[API] Warning: Plugin uses .read/.rebuild API: Filter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
@rwjblue
Copy link
Member

rwjblue commented Jul 17, 2018

Thank you for reporting!

@jrjohnson
Copy link

And now the next Broccoli version. When I attempt to run EMBER_CLI_BROCCOLI_2=true ember build I get the following error:

TemplateLinter: The .read/.rebuild API is no longer supported as of Broccoli 1.0. Plugins must now derive from broccoli-plugin. https://github.com/broccolijs/broccoli/blob/master/docs/broccoli-1-0-plugin-api.md

@rwjblue
Copy link
Member

rwjblue commented Jul 25, 2018

This is fixed on master and will soon be released as 1.0.0-beta.1 (had to drop some Node versions)...

@pichfl
Copy link
Author

pichfl commented Jul 27, 2018

I have updated one of our projects to 1.0.0-beta.1 and the warnings still show. I can provide you with access to the repository if that would help, but it's not public.

@jrjohnson
Copy link

Same as @pichfl. We updated https://github.com/ilios/frontend to [email protected] and ember-template-lint@^1.0.0-beta.2 and are still seeing these errors when running ember serve.

@rwjblue
Copy link
Member

rwjblue commented Aug 9, 2018

Hmm. I really do not grok what’s going on. I explicitly added tests in Broccoli 2 land and all pass without error or warning.

Can someone help me with a reproduction?

@rwjblue
Copy link
Member

rwjblue commented Aug 9, 2018

Is ilios/frontend a good place to poke around?

@jrjohnson
Copy link

Yes. It's probably a lot more reproduction than you need but you're more than welcome to poke around there.

@jrjohnson
Copy link

An update: just upgraded ilios/frontend to [email protected] and I'm still seeing these errors:

$ yarn list --pattern template-lint
yarn list v1.9.4
├─ [email protected]
└─ [email protected]
✨  Done in 0.92s.

$ yarn start
yarn run v1.9.4
$ ember serve
<---snip some build stuff --->

[API] Warning: The .read and .rebuild APIs will stop working in the next Broccoli version
[API] Warning: Use broccoli-plugin instead: https://github.com/broccolijs/broccoli-plugin
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter
[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter

<-- snip some new linting errors --->
===== 10 Template Linting Errors

[API] Warning: Plugin uses .read/.rebuild API: TemplateLinter

Build successful (59124ms) – Serving on http://localhost:4200/

@rwjblue
Copy link
Member

rwjblue commented Sep 9, 2018

Ok, thanks for the reminder. Will dig in here, to see what is going on...

@rwjblue
Copy link
Member

rwjblue commented Sep 10, 2018

AHA! I just cloned ilios/frontend and dug into the problem. It turns out that the console warnings that you are still seeing are actually coming from ember-cli-deprecation-workflow which ironically calls its broccoli plugin base class TemplateLinter 🤦‍♂️ therefore throwing us off the trail...

Confirmed by removing ember-cli-deprecation-workflow from the package.json of ilios/frontend, and seeing no warnings.

Will close this issue and track over in ember-cli/ember-cli-deprecation-workflow#52.

@rwjblue rwjblue closed this as completed Sep 10, 2018
@Alonski
Copy link

Alonski commented Nov 14, 2018

@rwjblue Can you please explain how you found that out? I have a few errors like this and I am not sure exactly from which package they come from

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants