Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components to extend glimmer/component and enable ember/no-classic-components rule #805

Open
7 of 11 tasks
geneukum opened this issue Jul 6, 2022 · 0 comments
Open
7 of 11 tasks

Comments

@geneukum
Copy link
Contributor

geneukum commented Jul 6, 2022

Right now, there are a bunch of classic components in ember-api-docs. It would be nice to work through those and upgrade them all to use native syntax and extend from glimmer/component. The components requiring modifications are:

  • app/components/api-index-filter.js
  • app/components/api-index.js
  • app/components/class-field-description.js
  • app/components/import-example.js
  • app/components/loading-spinner.js
  • app/components/search-input.js
  • app/components/search-input/dropdown-header.js
  • app/components/search-input/dropdown-result.js
  • app/components/search-input/dropdown.js
  • app/components/table-of-contents.js

Once we've done this we should then:

  • re-enable the ESLint rule: 'ember/no-classic-components'

to prevent us from accidentally adding any legacy style components going forward.

@geneukum geneukum changed the title Resolve ember/no-classic-components deprecation Enable ember/no-classic-components rule Jul 6, 2022
@geneukum geneukum changed the title Enable ember/no-classic-components rule Update components and enable ember/no-classic-components rule Jul 6, 2022
@geneukum geneukum changed the title Update components and enable ember/no-classic-components rule Update components to extend glimmer/component and enable ember/no-classic-components rule Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant