Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LastModified comparison not working with AWS-SDK 2.29+ #4

Closed
bobisjan opened this issue Mar 21, 2017 · 4 comments
Closed

LastModified comparison not working with AWS-SDK 2.29+ #4

bobisjan opened this issue Mar 21, 2017 · 4 comments

Comments

@bobisjan
Copy link
Contributor

bobisjan commented Mar 21, 2017 •
edited
Loading

Hi,

in AWS SDK v2.29.0 the type of LastModified has changed from string to object, so comparison at line doesn't work as expected.

Jan
@nanaewusi
Copy link

It is same for me. Results in false positives:

screen shot 2017-03-21 at 10 59 45 pm

habdelra pushed a commit to habdelra/fastboot-s3-notifier that referenced this issue Mar 25, 2017
Fixes ember-fastboot#4 converts dates to strings before comparing them
474290e
@bcardarella bcardarella mentioned this issue Mar 27, 2017
Merged
@chuck
Copy link

chuck commented May 10, 2017

Could we please get a new release of fastboot-s3-notifier that includes this fix?

@tomdale
Copy link
Collaborator

tomdale commented May 11, 2017

Published 0.1.2

@chuck
Copy link

chuck commented May 12, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chuck @tomdale @bobisjan @nanaewusi