Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow imports from ember-data/store #2162

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Sep 18, 2024

This adjusts the use-ember-data-rfc-395 rule so imports from ember-data/store are allowed.

It is a valid import according to the deprecation guides: https://deprecations.emberjs.com/id/ember-data-deprecate-legacy-imports/

Closes #2156

This adjusts the `use-ember-data-rfc-395` rule so imports from `ember-data/store` are allowed.

It is a valid import according to the deprecation guides: https://deprecations.emberjs.com/id/ember-data-deprecate-legacy-imports/
@NullVoxPopuli NullVoxPopuli merged commit b19a016 into ember-cli:master Sep 18, 2024
8 checks passed
@Windvis Windvis deleted the use-ember-data-rfc-395-imports/allow-ember-data-store branch September 18, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use-ember-data-rfc-395-imports should ignore ember-data/store
2 participants