Fix deprecation blocking eslint v9 #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Failing because 98.95% < 99% haha, not sure how to resolve that. |
I think you could reduce the target coverage to |
@NullVoxPopuli done! |
NullVoxPopuli
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR I originally thought I had completely unblocked usage of this plugin with eslint v9. However, there was at least 1 other issue. I believe this is the final issue, as I can use the plugin now without errors in a large ember code base. I did start to try running the unit tests in this project under v9, but there are a significant number of test eslint configs that need to be reformatted to be compatible with v9. I did a spot check and all of those tests pass, but I wasn't sure if the effort of fixing all those would be desired yet, since I don't know if this project is ready to commit to only testing under eslint v9.
Regardless, I hope this PR can go in and be released, I know many teams would appreciate being able to use eslint v9. Thank you!