Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bower optional #101

Closed
stefanpenner opened this issue Oct 10, 2016 · 4 comments
Closed

make bower optional #101

stefanpenner opened this issue Oct 10, 2016 · 4 comments

Comments

@stefanpenner
Copy link
Contributor

stefanpenner commented Oct 10, 2016

We don't want to download bower unless the host application actually needs it.

Now that: emberjs/ember.js#13022 has landed, we need to get the ball rolling on dropping bower from our default installations.

RFC tracking issue: ember-cli/rfcs#41

@kategengler
Copy link
Member

@stefanpenner Do you have any more details on what is required here?

I believe bower isn't a requirement of ember-try unless the bower key is used in the config. It is currently used in the default config, so it is required by anybody not overriding the config, but I believe it has to stay that way until the default scenarios are all available via npm (release, beta and canary).

@stefanpenner
Copy link
Contributor Author

my thoughts where to identify what required it, and then optionally download it if the users truly need it. Rather then forcing all ember-cli installs to download it.

Although we don't quite have all versions of ember on npm, hopefully we will soon. And if we can make ember try lazily depend on bower (by downloading it on-demand) we are on the path to reducing ember-cli's download size dramatically.

@kategengler
Copy link
Member

@stefanpenner I understand the motivations. What I'm saying is that that I think it's already optional from the perspective of ember-try. It doesn't use bower programmatically and will only try to read bower.json or use bower through spawn if there is a bower key in the config.

The default config (and the one generated by ember-cli) both currently have a bower key, but once that is removed, it won't try to use bower (and wouldn't have downloaded it either way -- just failed hard because of the absence).

@stefanpenner
Copy link
Contributor Author

@kategengler you are correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants