Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should recommend import { inject as service } from '@ember/service' instead of { inject } #57

Open
seanjohnson08 opened this issue May 23, 2018 · 1 comment
Open

Should recommend import { inject as service } from '@ember/service' instead of { inject } #57

seanjohnson08 opened this issue May 23, 2018 · 1 comment
Labels
enhancement

Comments

@seanjohnson08
Copy link

The linter suggests using { inject }, but so many other places (including the code mod) switch it to { inject as service }. It should be consistent throughout.
@Turbo87
Copy link
Member

Turbo87 commented Nov 28, 2018

@seanjohnson08 I agree, do you want to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rwjblue @locks @Turbo87 @seanjohnson08