-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcemaps Are Not Valid OTB #7237
Comments
I wonder if they went bad post babel |
i suspect it's something else. Maybe keep removing stuff until it works again |
Another idea is to run the validation within broccoli concat and see which inputs are breaking (or if broccoli concat itself is breaking them) |
Also the above looks like a great test to add to ember-cli's test suite. |
@stefanpenner I don't think that it belongs in the test suite of Ember CLI since this is likely an issue in either the Babel or UglifyJS addon |
it seems that @chadhietala has figured out that Babel sourcemaps are broken: babel/babel#6008 |
Steps To Reproduce
ember new my-app --yarn=true
ember build --environment=production
yarn add sourcemap-validator --dev
require("sourcemap-validator")(fs.readFileSync('./dist/assets/app-SOMEHASH.js', './dist/assets/app-SOMEHASH.map'))
I have also noticed that out of the box all the col numbers are 0.
Ember Versions
Yarn Version
The text was updated successfully, but these errors were encountered: