Bumping to 1.1.0 stops tests from running

[oliverwilkie]

Ember CLI version: 1.13.13

Bumping from 1.0.5 to 1.1.0 stops my tests from running with the following output

I made sure I deleted ember-qunit

Error: Assertion Failed: The tests file was not loaded. Make sure your tests index.html i
ncludes "assets/tests.js". at http://localhost:7357/assets/vendor.js, line 16471
Error: Could not find module `ember-qunit` imported from `dispatcher/tests/test-helper` a
t http://localhost:7357/assets/vendor.js, line 144

Let me know what else I can provide.

[rwjblue]

Can you create an empty repo that demonstrates the issue? I'd love to dig in, and a reproduction will be very helpful...

[oliverwilkie]

Of course, here it is [https://github.com/oliverwilkie/dispatcher] .I basically just did an ember init and then copied my test files and package.json and bower.json over

[oliverwilkie]

Check that out and then run ember test --server using Ember CLI 1.13.13 and you should get the same message

[rwjblue]

Awesome, thank you! Will try to look soon.

[stefanpenner]

Of course, here it is [https://github.com/oliverwilkie/dispatcher] .I basically just did an ember init and then copied my test files and package.json and bower.json over

@oliverwilkie this app is crashing by default, because it does not have a fully installed ember-cli-mirage. Please be sure your reproduction is for the issue you have.

[stefanpenner]

Error: Could not find module ember-qunit imported from dispatcher/tests/test-helper a
t http://localhost:7357/assets/vendor.js, line 144

this error appears to be a side-affect of another error, scrolling up we see.

Which indicates someone is trying to require without a name, which will clearly fail.

[stefanpenner]

@duboff something in your vendor.js is crashing, likely do to syntax error or some other runtime error. Please investigate that thoroughly If you cannot figure it out, please open a new discrete issue with a reproduction.

[duboff]

Yeah, I figured our issue is different but cannot reproduce it now. Probably one of the other addons

[stefanpenner]

@oliverwilkie source of the issue appears to be something in ember-cli-mock-socket without it, everything seems to work correctly.

This does not appear to be an ember-cli issue, rather something funky with an upstream dependency. Unfortunately we do not have the capacity to consider what appears to be a bug in a non-default package addon. If it turns out something is wrong in ember-cli we can reopen.

[stefanpenner]

My quick guess is that an upgraded mock-socket would fix it. as it appears to have relevant changes since the version bundled with ember-cli-mock-socket was released.

[oliverwilkie]

Thanks for looking into it!