Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Pull QUnit From NPM Instead Of Bower #26

Closed
chadhietala opened this issue Jan 19, 2015 · 6 comments
Closed

Pull QUnit From NPM Instead Of Bower #26

chadhietala opened this issue Jan 19, 2015 · 6 comments
Assignees

Comments

@chadhietala
Copy link
Member

This probably requires ember-cli/ember-cli#2381 and also @ef4's ember-browserify.

@rwjblue
Copy link
Member

rwjblue commented Jan 19, 2015

Why? Is this an overall strategy (moving off of Bower) or just something for this library? If this is a general strategy, then we should likely have an RFC to make the formal decision to switch our current default Bower deps to NPM deps (and potentially stop requiring Bower at all).

@chadhietala
Copy link
Member Author

Yes, moving off of bower. I think we can get down to 1 package management system for "core" addons or libraries to see how it goes. This just seems like low hanging fruit since QUnit is already published to NPM. We can close for now if you would like.

@chadhietala chadhietala self-assigned this Jan 19, 2015
@stefanpenner
Copy link
Contributor

@chadhietala lets try this. I am also eager for a single package management system, ember-cli-qunit seems like as good a place as any to start.

@dgeb
Copy link
Member

dgeb commented Jan 19, 2015

The dependency management strategies for npm and bower aren't compatible. From my perspective, neither is ideal (or even very good) but both have distinct advantages and disadvantages.

I'm not particularly nervous about pulling test support files from npm. However, once we get into assets that may be bundled for production, I think this deserves a larger discussion.

@Turbo87
Copy link
Member

Turbo87 commented Apr 25, 2016

@chadhietala @rwjblue I think this issue has been resolved, right?

@trentmwillis
Copy link
Member

Resolved as of #93.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants