Adjust error message for re-exported class when it has a co-located template #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (hasTemplate && !jsContents.includes('export default')) { | ||
| let message = `\`${relativePath}\` does not contain a \`default export\`. Did you forget to export the component class?`; | ||
| if (hasTemplate && jsContents.includes('export { default }')) { | ||
| let message = `\`${backingClassPath}\` contains an \`export { default }\` re-export, but it has a co-located template. You must explicitly extend the component to assign it a different template.`; |
NullVoxPopuli
approved these changes
Aug 1, 2023
robinborst95
deleted the
fix/co-located-template-with-re-exported-class-error-message
branch
|
It doesn't appear CI ran here |
|
🙈 should we add some required checks to github for the CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #772, the error message for re-exported classes with a different template is not very descriptive. This PR fixes that, let me know what you think of this new error message. Note that I adjusted the file path of the other error message as well, as it contained
.hbs, while in fact the error was about the.jsfile.