Only check semver range if ember-source is present #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch the value `false` would be passed to `semver.gte(` causing an exception of `Invalid Version: false`. This ensures the range validity of the version is only checked if one is present. Specifically bower versions of Ember have an `emberVersion` of `false` here. However none of those versions of Ember support co-location. Fixes ember-cli#422
rwjblue
force-pushed
the
mixonic/invalid-version-exception
branch
from
26ffeca to
bb8a57f
Compare
rwjblue
changed the title
|
Looks good to me, I just pushed a minor formatting tweak (so the ember guard matches the babel one). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch the value
falsewould be passed tosemver.gte(causing an exception ofInvalid Version: false. This ensures the range validity of the version is only checked if one is present.Specifically bower versions of Ember have an
emberVersionoffalsehere. However none of those versions of Ember support co-location.Fixes #422