Support TypeScript merging of export default declarations in template colocation #677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TypeScript it's possible to merge together multiple interfaces by redeclaring them, and one occasional use for this is to declare that a class meets a certain interface in a way that isn't statically visible (such as the way
@ember/component
s "implement" their args by splatting them on to the instance).For a default export, though, this can result in multiple
ExportDefaultDeclaration
s in one module:This is legal (since the TS plugin ultimately strips out the interface), but currently causes an error in the colocation plugin because we try to associate the template with the interface declaration rather than the class:
This PR adds a check to ensure that the item we're attempting to associate the template to is either a class declaration or an expression so that we correctly skip the interface.