Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

willDestroy should be willDestoryElement #15

Open
Frozenfire92 opened this issue Mar 20, 2018 · 1 comment
Open

willDestroy should be willDestoryElement #15

Frozenfire92 opened this issue Mar 20, 2018 · 1 comment

Comments

@Frozenfire92
Copy link

I'm not sure if both will work, just noticed it was inconsistent with ember docs

https://guides.emberjs.com/v3.0.0/components/the-component-lifecycle/#toc_detaching-and-tearing-down-component-elements-with-code-willdestroyelement-code

@trentmwillis
Copy link
Member

Both are fine (as the tutorial here is definitely correct), but I believe willDestroyElement is now the preferred method. willDestroy is still a public method in the component API through v3.0. We can probably should update the tutorial to use willDestroyElement to keep it inline with the rest of the community best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants