Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axe.a11yCheck throws errors in nested components #29

Closed
BrianSipple opened this issue Jun 17, 2016 · 2 comments
Closed

axe.a11yCheck throws errors in nested components #29

BrianSipple opened this issue Jun 17, 2016 · 2 comments

Comments

@BrianSipple
Copy link
Member

BrianSipple commented Jun 17, 2016

[Note] I think this is actually a larger issue in axe-core -- and I PR'd my proposed changes for it there -- but I also wanted to make a note here for the purposes of cross-referencing and to offer an idea for how we can address it in the meantime...

I'm seeing (so far) two different errors in the console when axe.a11yCheck is called on a form component with nested components:

  1. With a single nested component:
    screen shot 2016-06-17 at 12 59 28 am
  2. With multiple nested components:
    screen shot 2016-06-17 at 12 58 37 am

I resolved it by making these changes in axe-core, however, for our purposes and the way we're using axe.a11yCheck, it seems like we can just as well pass in string of the element ID as a selector with the changes here.

Interestingly, the violations still register everything appears to run as expected -- but then the errors in the console do appear to cause the ember-inspector to crash.

@nathanhammond
Copy link
Contributor

Okay, that's definitely an error in axe-core. I'm trying to get somebody from Deque to look at it. 😄 I'd rather fix this once and for all upstream than work around it here.

@nathanhammond
Copy link
Contributor

Upstream has been resolved. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants