-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to Support Ember Octane? #121
Comments
@EndangeredMassa I haven't looked into Ember Octane yet, so I don't have direct insight into what the problem may be. I'm assuming the error is coming up from the visual component audit feature? The scheduler is just a simple queue mechanism that ensures axe.run is executed synchronously. Otherwise, asynchronous execution will result in the exception that you printed out above. What would be the quickest way to reproduce the issue? |
@EndangeredMassa - I think that the fix from #110 should still work in octane apps, but the integration (at the moment) is based on |
@EndangeredMassa is this concern still valid? I've played around with a bunch of different versions of Ember w/Octane features and haven't been able to reproduce, at least not when setting up a new app. If this is still an issue, we'll need a reliable way to reproduce, otherwise I recommend closing the issue. |
Using ember-a11y-testing on an Ember Octane app, I see a lot of:
It seems that this is a known issue of axe-core #1041. A workaround was implemented in #110 but that doesn't appear to work in an Ember Octane app.
I don't know much about the details of the scheduler. @drewlee do you have any thoughts on how we could support Octane?
The text was updated successfully, but these errors were encountered: