Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to Support Ember Octane? #121

Closed
EndangeredMassa opened this issue Apr 2, 2019 · 3 comments
Closed

Fails to Support Ember Octane? #121

EndangeredMassa opened this issue Apr 2, 2019 · 3 comments

Comments

@EndangeredMassa
Copy link
Contributor

Using ember-a11y-testing on an Ember Octane app, I see a lot of:

Error: Expect axe._selectorData to be set up
    at generateSelector (axe.js:4837)
    at Object.createUniqueSelector [as getSelector] (axe.js:4893)
    at DqElement.get selector [as selector] (axe.js:4265)
    at axe.js:3774
    at Array.map (<anonymous>)
    at axe.js:3767
    at Array.map (<anonymous>)
    at axe.js:3764
    at Array.forEach (<anonymous>)
    at Object.helpers.processAggregate (axe.js:3756)

It seems that this is a known issue of axe-core #1041. A workaround was implemented in #110 but that doesn't appear to work in an Ember Octane app.

I don't know much about the details of the scheduler. @drewlee do you have any thoughts on how we could support Octane?

@drewlee
Copy link
Contributor

drewlee commented Apr 2, 2019

@EndangeredMassa I haven't looked into Ember Octane yet, so I don't have direct insight into what the problem may be. I'm assuming the error is coming up from the visual component audit feature? The scheduler is just a simple queue mechanism that ensures axe.run is executed synchronously. Otherwise, asynchronous execution will result in the exception that you printed out above. What would be the quickest way to reproduce the issue?

@rwjblue
Copy link
Member

rwjblue commented Apr 9, 2019

@EndangeredMassa - I think that the fix from #110 should still work in octane apps, but the integration (at the moment) is based on Ember.Component/@ember/component which isn't used (too much) in an octane app (you'd use @glimmer/component instead). In order to help track down the specific error you hit, would you mind pushing up a repo that demonstrates the error?

@drewlee
Copy link
Contributor

drewlee commented Aug 7, 2019

@EndangeredMassa is this concern still valid? I've played around with a bunch of different versions of Ember w/Octane features and haven't been able to reproduce, at least not when setting up a new app. If this is still an issue, we'll need a reliable way to reproduce, otherwise I recommend closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants