Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to axe-core v3 #106

Closed
drewlee opened this issue Jul 18, 2018 · 4 comments
Closed

Upgrading to axe-core v3 #106

drewlee opened this issue Jul 18, 2018 · 4 comments

Comments

@drewlee
Copy link
Contributor

drewlee commented Jul 18, 2018

There have been quite a number of features and bug fixes introduced into axe-core v3 (https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md). Are there any plans in the pipeline to update axe-core dependency to the latest release? Thanks!
@drewlee
Copy link
Contributor Author

drewlee commented Aug 3, 2018

Hey there, seeing as there hasn't been much of a response, I don't have issue with taking up ownership in bumping up the version of axe-core. After checking what the work effort looks like, I did run into an issue in the fact that axe.run can no longer be run concurrently (dequelabs/axe-core#1041). Obviously a problem when each component kicks off an audit. Seeing if this can be addressed on their end before implementing a workaround within this addon itself. Thanks!

@Robdel12
Copy link
Member

Robdel12 commented Aug 3, 2018

Awesome! Thank you for taking this on :D

@drewlee
Copy link
Contributor Author

drewlee commented Sep 24, 2018

I've created a pull request: #109.

@drewlee
Copy link
Contributor Author

drewlee commented Oct 2, 2018

Fixed by #109

@drewlee drewlee closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drewlee @Robdel12