Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd: Sorting all translate files & Turkish strings translated. #396

Closed
wants to merge 1 commit into from

Conversation

ramazansancar
Copy link

@ramazansancar ramazansancar commented Jan 7, 2024

upd: Sorting all translate files
upd: Turkish language translation has been updated.

I refactored the Translate Tool to make it suitable for this project and edited it.

Translate Tool: https://github.com/ramazansancar/AndroidStringXmlTranslator

Translate Tool Source: https://jtbrinkmann.de/tools/android-strings.xml-translator.html (Source: https://github.com/yuliskov/SmartTube > "Translate the app") Contrubitor: @yuliskov

upd: Turkish language translation has been updated.
@emanuele-f
Copy link
Owner

Hello, PCAPdroid relies on weblate for translations. Your changes would probably create conflicts with it and be overwritten by the changes performed on weblate

@ramazansancar
Copy link
Author

Hello, PCAPdroid relies on weblate for translations. Your changes would probably create conflicts with it and be overwritten by the changes performed on weblate

I tried to translate from Weblate, but the pipeline was broken there. That's why it can only be accessed as read-only and cannot be updated. @emanuele-f

@emanuele-f
Copy link
Owner

I see, thanks for reporting this, I will check

@ramazansancar
Copy link
Author

I see, thanks for reporting this, I will check

Do we include this PR? @emanuele-f

@emanuele-f
Copy link
Owner

@ramazansancar we cannot merge this, otherwise it will conflict with weblate.

On weblate I can see the "The VCS repository is not up to date" alert, but that does not prevent me from creating new strings. Can you send a screenshot of the warning/error which does not allow you to make modifications there?

@ramazansancar
Copy link
Author

@ramazansancar we cannot merge this, otherwise it will conflict with weblate.

On weblate I can see the "The VCS repository is not up to date" alert, but that does not prevent me from creating new strings. Can you send a screenshot of the warning/error which does not allow you to make modifications there?

All translate: "This string is read-only"

image

@emanuele-f
Copy link
Owner

That string was set readonly by me, because it's the app name and should not be translated. Clicking on the "not translated" filter allows you to see only the strings that need to be translated

@ramazansancar
Copy link
Author

That string was set readonly by me, because it's the app name and should not be translated. Clicking on the "not translated" filter allows you to see only the strings that need to be translated

This is the case for all strings. @emanuele-f

@emanuele-f
Copy link
Owner

@ramazansancar sorry for the late reply. I will check this issue in more detail just before the 1.7.0 release. In any case, your strings will be integrated, either via this PR or via weblate (possibly via its "import" feature)

@ramazansancar
Copy link
Author

@ramazansancar sorry for the late reply. I will check this issue in more detail just before the 1.7.0 release. In any case, your strings will be integrated, either via this PR or via weblate (possibly via its "import" feature)

Thanks

@emanuele-f
Copy link
Owner

I've fixed the issues on the weblate platform and updated the translations. Only 21 strings remain to be translated on weblate, so please update the translation there. If you have any issue please post a new screenshot here.

2024-02-02_11-00

@ramazansancar
Copy link
Author

I've fixed the issues on the weblate platform and updated the translations. Only 21 strings remain to be translated on weblate, so please update the translation there. If you have any issue please post a new screenshot here.

2024-02-02_11-00

I'll take a look when I'm free

@emanuele-f
Copy link
Owner

Another user has already updated the Turkish translation, so I'm closing this.

@emanuele-f emanuele-f closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants