Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom rules per app #374

Closed
anpic opened this issue Dec 12, 2023 · 8 comments
Closed

Custom rules per app #374

anpic opened this issue Dec 12, 2023 · 8 comments

Comments

@anpic
Copy link

anpic commented Dec 12, 2023

Thank you so much for your program :)
Are you planning to add host/ip whitelist and blocklist per application?
As I understand it, there is only a single global whitelist and blocklist now.

@emanuele-f
Copy link
Owner

Hello, thanks for your feedback. Can you provide more insights on your use case for this feature?

@anpic
Copy link
Author

anpic commented Dec 13, 2023

Can you provide more insights on your use case for this feature?

It's often necessary to manage addresses individually in each app.
How is this done in Rethink
https://github.com/celzero/rethink-app
There are both general lists for all apps and separate ones for each app.
But Rethink isn't so good at blocking completeness as yours!

@emanuele-f
Copy link
Owner

Thanks for the pointers. As this will add more complexity to the app, unless we have a specific use case which is worth, this is a feature I would reject

@anpic
Copy link
Author

anpic commented Dec 13, 2023

unless we have a specific use case which is worth

Well, does the application need to be allowed to go to some addresses and not be allowed to go to others? Specifically for a separate application.
This includes blocking ads and trackers in individual applications.
How do I do this without affecting other applications?

@anpic
Copy link
Author

anpic commented Dec 13, 2023

This is a common feature in all configurable firewalls.

@emanuele-f
Copy link
Owner

This includes blocking ads and trackers in individual applications.

See #375 (comment) :D

How do I do this without affecting other applications?

Yeah I understand. But as explained in the linked comment, this use case is quite problematic for the survival of the app. I will keep your suggestion in consideration, but at the current stage I would not go this path

@anpic
Copy link
Author

anpic commented Dec 13, 2023

but at the current stage I would not go this path

It's up to you :)
But other firewalls have been around for many years.
After all, you've already added functionality in the form of a separate plugin.

@emanuele-f
Copy link
Owner

Not planned for now

@emanuele-f emanuele-f closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants