-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal rule in markdown forces max width popup #442
Comments
And I looked through the lsp-ui code, have no idea where this is happening. |
i went ahead and closed the other issue, #449, as duplicate, but this is happening with the Rust docs as well. |
I had that same issue with
Apparently |
Can we add this to that replacement as well? Or is that not a viable solution? Any hacks that would help in the short term..? |
@bryandmc @covercash2 I am updating the hacky regex, to include what haskell uses, Is there anything else that should be added? Should it be a substitution instead? |
I guess the other option is setting markdown-hr-display-char to nil. I guess this will prevent rendering of the hrs |
The complete solution will be to do a PR against markdown-mode to allow setting width in markdown-fontify-hrs . |
I have proposed an expanded list of "bad" elements in emacs-lsp/lsp-mode#1750. And learned about |
BTW this doesn't seem to have fixed it.. At least on my side. It looks like the horizontal rule is still there. |
@bryandmc can you show the log + screenshot so we can find out what is causing the issue? |
I think we are going to have to add case-by-case exceptions, based on real world reports. See how many things map to |
Another hacky solution will be to flet |
I'm on Emacs-28 on my usage with 3 languages Python,Go & Rust I can see the problem. This issue can be kept open until it solves for most of users. |
@yyoncho What log are you looking for specifically (what log?)? I'm only a novice emacs+elisper but I'm a professional programmer so I can probably handle relatively short directions if you got them.. |
is this fixed |
It is for additional cases. Unfortunately, there are apparently a lot of ways to specify the |
If a hover response includes a markdown HR (
* * *\n
), then the width calculation for the hover window calculates it as the full width of the window. Exampleresults in
I have narrowed the window for the screenshot, if I maximise it uses the full width.
The text was updated successfully, but these errors were encountered: