Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for modifying history #262

Closed
huiyiqun opened this issue Oct 12, 2016 · 9 comments
Closed

API for modifying history #262

huiyiqun opened this issue Oct 12, 2016 · 9 comments

Comments

@huiyiqun
Copy link
Contributor

So that we could import histories from other shells.

@zhsj
Copy link
Contributor

zhsj commented Oct 12, 2016

And then we can implement completer with history in pure elvish lang.

@huiyiqun
Copy link
Contributor Author

@huiyiqun
Copy link
Contributor Author

huiyiqun commented Oct 12, 2016

However, history is a concept only available in line editor currently, I'm not sure how should I expose this concept in eval gracefully. Maybe a new separate go package?

@xiaq

@huiyiqun
Copy link
Contributor Author

@zhsj you could use the history builtin

@huiyiqun
Copy link
Contributor Author

There is already store package.

@huiyiqun
Copy link
Contributor Author

We could use store/cmd.go directly. I will try to fix #263 first.

@xiaq xiaq changed the title API for history API for modifying history Oct 13, 2016
@xiaq
Copy link
Member

xiaq commented Oct 13, 2016

The variable $le:history allows reading the history, so what lacks is a API for modifying history. I have changed the title of the issue.

@xiaq xiaq added this to the 0.14 milestone Mar 8, 2018
@xiaq xiaq removed this from the 0.15 milestone Apr 6, 2019
@krader1961
Copy link
Contributor

See also issue #1205 where I pointed out that dir-history should not be in the builtin: namespace and manipulating the interactive history should be possible independent of whether the shell is interactive.

@xiaq
Copy link
Member

xiaq commented Oct 5, 2021

This is now supported by store:add-cmd \o/

@xiaq xiaq closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants