Skip to content
This repository has been archived by the owner on Aug 23, 2018. It is now read-only.

Why force GitHub as the place to host code? #267

Closed
joshuabyler opened this issue Mar 27, 2017 · 3 comments
Closed

Why force GitHub as the place to host code? #267

joshuabyler opened this issue Mar 27, 2017 · 3 comments

Comments

@joshuabyler
Copy link

joshuabyler commented Mar 27, 2017

In Description.hs the following code

dropDomain :: String -> Either String String
dropDomain string =
  let
    http = "http://github.com/"
    https = "https://github.com/"
  in
    if List.isPrefixOf http string then
        Right (drop (length http) string)

    else if List.isPrefixOf https string then
        Right (drop (length https) string)

    else
        Left (repoProblem "The given domain does not start with <https://github.com/>")

forces the repository field in elm-package.json to start with http://github.com/ or https://github.com/. I wanted to host my code elsewhere, and got an error message, I had to enter just a random https://github.com/random.git to get elm-package install to run correctly.

Can this requirement be changed?

I am using ELM 0.18.0 on Mac OS 10.12.3.
To reproduce the error, create a elm-package.json and change the repository field to something that does not start with http://github.com/ or https://github.com/.

@process-bot
Copy link

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@jvoigtlaender
Copy link
Contributor

See #189 and elm-lang/elm-make#59 and various other issues referenced from those.

Your new issue here is redundant.

@joshuabyler
Copy link
Author

@jvoigtlaender: thanks for pointing that out I didn't see those issues earlier. closing this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants