Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP Warning] PHP depreciation warning #477

Closed
TheGuardianLight opened this issue Aug 6, 2024 · 4 comments · Fixed by #479
Closed

[PHP Warning] PHP depreciation warning #477

TheGuardianLight opened this issue Aug 6, 2024 · 4 comments · Fixed by #479
Assignees
Labels
bug Something isn't working Completed Feature is implemented and merged

Comments

@TheGuardianLight
Copy link

Hi !

I've upgraded to 2.21.0 and PHP tells me this on the "admin.php" page:

Deprecated
: version_compare(): Passing null to parameter #2 ($version2) of type string is deprecated in
/var/www/html/admin.php
on line
241

This is obviously displayed because I've enabled the option in the PHP settings.

@ellite
Copy link
Owner

ellite commented Aug 6, 2024

Hi. Thank you for the report.
Yes, I have noticed but unfortunately I can't fix it at the moment. Only later today I will have time.
In the meantime you can run ip:port/endpoints/cronjobs/checkforupdates.php
Should also go away once the cronjob runs. (Every 6 hours)
Regards.

@TheGuardianLight
Copy link
Author

Thanks ! I will wait for the cron to run ;)

@ellite ellite self-assigned this Aug 6, 2024
@ellite ellite added bug Something isn't working Completed Feature is implemented and merged labels Aug 6, 2024
@ellite ellite linked a pull request Aug 6, 2024 that will close this issue
@ellite
Copy link
Owner

ellite commented Aug 6, 2024

v2.21.1 released and should fix that warning.

@TheGuardianLight
Copy link
Author

Yup, it's fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Completed Feature is implemented and merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants