Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of get secret requests #1779

Open
jmikedupont2 opened this issue Jan 3, 2025 · 2 comments
Open

Reduce the number of get secret requests #1779

jmikedupont2 opened this issue Jan 3, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@jmikedupont2
Copy link

Noticed while starting to trace the number of calls to functions in otel that the number of calls to get secrets was very high
Screenshot_20250103_170724_Chrome.jpg
Screenshot_20250103_170431_Chrome.jpg

Describe the solution you'd like

Reduce number of calls to secrets

Describe alternatives you've considered

Optionally disable checking for certain secrets

Additional context

More research is needed.

see branch here on how I produced this.
https://github.com/meta-introspector/cloud-deployment-eliza/pulls

@jmikedupont2 jmikedupont2 added the enhancement New feature or request label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Hello @jmikedupont2! Welcome to the ai16z community. Thank you for opening your first issue; we appreciate your contribution. You are now a ai16z contributor!

@jmikedupont2
Copy link
Author

I have removed the calls via commenting out hard coded modules in agent.ts, will load them via a plugin system later, i want to only read in parameters for modules loaded and not have them in memory at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant