Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unification of handling weights passed as arguments to functions #249

Closed
msluszniak opened this issue Apr 6, 2024 · 2 comments
Closed
Labels
suggestion ideas and/or plans to put forward for consideration.

Comments

@msluszniak
Copy link
Contributor

As mentioned here we want to unify the way we pass the weights in Scholar to the algorithms. Currently, there are a few ways that we do it. For example, we pass them as tensors or as a list via opts.

@msluszniak msluszniak added the suggestion ideas and/or plans to put forward for consideration. label Apr 6, 2024
@JoaquinIglesiasTurina
Copy link
Contributor

I would like to take a stab at this one, particularly regarding linear methods.
I think this would also be a great opportunity to DRY up some of the duplication of private functions that's spreading over there.
So far, the better approach I've found is to move all these functions to a helper module, make them public,
but make sure to set @moduledoc false and @doc false. My proof of concept is here.
Is this the best approach to handle this? Or should I take an alternative approach?

@msluszniak
Copy link
Contributor Author

Yes, this looks great! You can send a PR with your improvements :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion ideas and/or plans to put forward for consideration.
Projects
None yet
Development

No branches or pull requests

3 participants