Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time-series regression example notebook #587

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Add time-series regression example notebook #587

merged 5 commits into from
Sep 5, 2024

Conversation

santiago-imelio
Copy link
Contributor

Adds simple notebook showcasing an example of time-series regression using RNN.

seanmor5
seanmor5 reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@seanmor5 seanmor5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job overall, I left some comments to change some of the style from passive to active.

seanmor5
seanmor5 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@seanmor5 seanmor5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@seanmor5 seanmor5 merged commit 57ed0c2 into elixir-nx:main Sep 5, 2024
@santiago-imelio santiago-imelio deleted the simelio/time-series-notebook branch September 6, 2024 21:09
@polvalente polvalente mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmor5 seanmor5 seanmor5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santiago-imelio @seanmor5