Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content headings #1972

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

DavidOliver
Copy link
Contributor

simplescreenrecorder-2024-11-26_15.04.06.mp4

Important

@josevalim, if you'd prefer the hover links to remain invisible until the heading is hovered/focussed, let me know and I'll revert that change.

Allows selection of heading text. Also makes hover link always (slightly) visible for discoverability.

Also improves:

  • hover link colour
  • hover link icon spacing
  • heading spacing

Fixes #1969

Allows selection of heading text. Also makes hover link always
(slightly) visible for discoverability.

Also improves:

- hover link colour
- hover link icon spacing
- heading spacing

Fixes elixir-lang#1969
@DavidOliver
Copy link
Contributor Author

I forgot to check the cheatsheet headings, which are also affected by making the hover link visible with a low opacity.

image

They don't show when previewing printing, but maybe this is a bit much? Should I revert for the cheatsheets, or even entirely?

@josevalim
Copy link
Member

Please let's keep it visible only on hover please.

And if we are going to change the color, can you please make sure it works with mix docs --proglang erlang? Generally speaking, I prefer to avoid accent, exactly because we need to make sure it works for both Erlang and Elixir, both on light and dark mode. So it is a bit too much. :)

@DavidOliver
Copy link
Contributor Author

DavidOliver commented Nov 26, 2024

👍 Done.

The accent colours are handled by the --main... custom properties, and tested in light and dark modes.

@josevalim josevalim merged commit a1a3da6 into elixir-lang:main Nov 26, 2024
5 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unable to select heading text
2 participants