0.34.0 changed handling of symbolic files in asset

[aYukiSekiguchi]

My asset files:

% ls -l doc_src/assets
total 40
lrwxr-xr-x  1 yukisekiguchi  staff     47 Nov 21 13:47 AntikytheraArchitecture.drawio.png -> ../../assets/AntikytheraArchitecture.drawio.png
lrwxr-xr-x  1 yukisekiguchi  staff     62 Nov 21 13:47 AntikytheraDeploymentFlow.drawio.png -> ../gear_developers/assets/AntikytheraDeploymentFlow.drawio.png
-rw-r--r--  1 yukisekiguchi  staff  17698 Nov 21 13:47 MemcacheExpiration.png
lrwxr-xr-x  1 yukisekiguchi  staff     56 Nov 21 13:47 RequestHandlingFlow.drawio.png -> ../gear_developers/assets/RequestHandlingFlow.drawio.png

Genearated doc files on 0.33.0

% ls -l doc/assets
total 1296
-rw-r--r--  1 yukisekiguchi  staff   59054 Nov 21 14:01 AntikytheraArchitecture.drawio.png
-rw-r--r--  1 yukisekiguchi  staff  418924 Nov 21 14:01 AntikytheraDeploymentFlow.drawio.png
-rw-r--r--  1 yukisekiguchi  staff   17698 Nov 21 14:01 MemcacheExpiration.png
-rw-r--r--  1 yukisekiguchi  staff  157773 Nov 21 14:01 RequestHandlingFlow.drawio.png

Genearated doc files on 0.34.0

% ls -l doc/assets
total 40
lrwxr-xr-x  1 yukisekiguchi  staff     47 Nov 21 14:08 AntikytheraArchitecture.drawio.png -> ../../assets/AntikytheraArchitecture.drawio.png
lrwxr-xr-x  1 yukisekiguchi  staff     62 Nov 21 14:08 AntikytheraDeploymentFlow.drawio.png -> ../gear_developers/assets/AntikytheraDeploymentFlow.drawio.png
-rw-r--r--  1 yukisekiguchi  staff  17698 Nov 21 14:08 MemcacheExpiration.png
lrwxr-xr-x  1 yukisekiguchi  staff     56 Nov 21 14:08 RequestHandlingFlow.drawio.png -> ../gear_developers/assets/RequestHandlingFlow.drawio.png

I believe this change was introduced by the following commit: f4a46cb

It changed the copy function from File.copy/3 to File.cp_r!/3, which altered the handling of symbolic files.

Is this an intentional change or a bug?

Note: I reproduced this issue in the following repository: https://github.com/access-company/antikythera

[josevalim]

That was not intentional. Can you please send a PR? It should be a matter of passing the :dereference_symlinks option as true to cp_r!

[aYukiSekiguchi]

Thank you for the advice!

I created a PR #1967