-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding support for deltalake file #843
Conversation
hey @cocoa-xu , thank you for this PR! I'm going to try to fix the missing parts if you don't mind. I'm going to open another branch to avoid conflicting with yours, but I'm going to be based on this branch, ok? |
No problem! |
@cocoa-xu could we perhaps use a library that converts delta lake to an arrow stream, and then we can use the existing logic in Alternatively, we could even have delta lake as a separate library, and all it need to do is to expose a pointer to arrow stream, similar to what we do in Adbc. In Adbc we do:
But we could export
WDYT? |
Yeah, I think perhaps I'll try to have delta lake as a separate library, at least it would be a good start point, and probably easier to debug (and possibly integrate it into explorer if it won't cause too much trouble to do so) |
So I read more in the deltalake repo and other relevant repos, and I found that we basically have to wait for the upstream to support ADBC. According to delta-rs issue #954 and the design doc of Delta Lake ADBC,
This was one of the difficulties I encountered here -- there's no easy way to cast from Currently, I think we should wait for
Once they're available, we can easily add support for deltalake to explorer. Besides that, we can try to replace current ADBC binding for Elixir https://github.com/elixir-explorer/adbc with the Rust version of ADBC if we want to and if it's possible/suitable for our use cases. |
ADBC sounds like a solid route forward. Shall we close this one then? |
Yeah I think we can close this one and wait for the ADBC version for it. |
This PR tries to add support for deltalake file, and should close #752 once it's done.