Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stable sorting to be turned off #554

Closed
josevalim opened this issue Mar 29, 2023 · 7 comments
Closed

Allow stable sorting to be turned off #554

josevalim opened this issue Mar 29, 2023 · 7 comments

Comments

@josevalim
Copy link
Member

Also verify if we should expose the multithreaded option during sorting or not.

@kimjoaoun
Copy link
Contributor

kimjoaoun commented Apr 14, 2023

Are there any downsides in exposing the multithreaded option?

@philss
Copy link
Member

philss commented Sep 19, 2023

Are there downsides in exposing the multithreaded option?

@kimjoaoun I don't think so. I think we can have both options. If you want to take this one, please go ahead!

@kimjoaoun
Copy link
Contributor

Are there downsides in exposing the multithreaded option?

@kimjoaoun I don't think so. I think we can have both options. If you want to take this one, please go ahead!

Nice, I'll take it.

@billylanchantin
Copy link
Contributor

Closed by: #771

@kimjoaoun Sorry! I didn't see that you'd called dibs on this.

@billylanchantin
Copy link
Contributor

@josevalim Oh I may have jumped the gun on this one. Can you confirm that #771 closed this?

@josevalim
Copy link
Member Author

It is all good!

@kimjoaoun
Copy link
Contributor

Closed by: #771

@kimjoaoun Sorry! I didn't see that you'd called dibs on this.

No problem at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants