Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend action to include prerelease #63

Closed
bwhitehead0 opened this issue Oct 29, 2024 · 2 comments
Closed

extend action to include prerelease #63

bwhitehead0 opened this issue Oct 29, 2024 · 2 comments
Assignees

Comments

@bwhitehead0
Copy link
Contributor

bwhitehead0 commented Oct 29, 2024

thoughts on extending the action to support? to include:

  • prerelease releases (priority)
  • additional release notes (might make sense)

could modify action.yaml to include under inputs:

  prerelease:
    description: "Is this a prerelease?"
    required: false
    default: "false"

and then update entrypoint.sh to read:

if [ -z "${INPUT_PRERELEASE}" ]; then
    gh release create $INPUT_TAG -t "${INPUT_TITLE}" --generate-notes
else
    gh release create $INPUT_TAG -t "${INPUT_TITLE}" --generate-notes --prerelease
fi

the way i'm using this workflow is in a generate_tagged_release workflow via workflow_dispatch, where our workflow enforces guidelines on versioning, tagging, and releases, and then kicks off subsequent build actions.

in this case, we could have both the release marked GA or prerelease, the user supplies the desired release tag matching our constraints (eg v1.2.1 or v1.2.1-RC for prerelease), which then creates the tag and release, ensuring conformity, and then kicks of subsequent build and other CI and CD processes, generating prerelease or GA artifacts and so on.

adding additional notes input might make sense for teams including additional info, links to release documentation, etc, which may not be available just from commit history etc.

@elgohr
Copy link
Owner

elgohr commented Oct 30, 2024

Let me think about it

@elgohr
Copy link
Owner

elgohr commented Nov 2, 2024

There you go
https://github.com/elgohr/Github-Release-Action?tab=readme-ov-file#prerelease

@elgohr elgohr closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants