Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect resume label on reopening completed short videos #187

Open
jeremypw opened this issue Apr 8, 2020 · 1 comment
Open

Incorrect resume label on reopening completed short videos #187

jeremypw opened this issue Apr 8, 2020 · 1 comment

Comments

@jeremypw
Copy link
Collaborator

jeremypw commented Apr 8, 2020

I have searched open and closed issues for duplicates.

Describe the bug

After ending a video and returning to the welcome page, the second button is labelled "Restart last video" as expected, but if the app is now closed and reopened the label reads "Resume last video".

To Reproduce

Steps to reproduce the behavior:

  1. Play a short video (e.g. 1 minute) and allow it to end
  2. Return to welcome page - observe label of second button
  3. Close app.
  4. Reopen app - observe label of second button

Expected behavior

The label of the button should not be changed by closing and reopening the app.

Elementary Hera daily.
I'm using the latest version from git that I've manually compiled

@jeremypw jeremypw changed the title Incorrect resume label on reopening Incorrect resume label on reopening completed short videos Apr 9, 2020
@danirabbit
Copy link
Member

From PR #186:

The problem seems to be that the "last-stopped" setting changes when the window is destroyed from "0" to "0.002..." for some reason. Note that this issue only seems to occur with_short_ videos (e.g. 1 minute)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants