Episode resume crash #193
Closed
Episode resume crash #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unable to reproduce a crash by resuming an episode as described above. Could you give more details (e.g. how exactly to interrupt and resume) or is there another way to reproduce the problem? |
|
This issue seems to be related to the Intel driver (see issue #200 resolution). I'll see if this PR works on a machine with an Intel driver (my current one has NVidia). |
|
I no longer have access to a machine with Intel video card so unfortunately I cannot do the necessary test. |
|
Are there any desktop-developers who can confirm the issue and review the fix? |
|
Is this still relevant? If so, can you please provide some more guidance on how to reproduce? I don't get any crash on my machine: |
|
Closing as no further response from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158 which was similar to the previous problem resuming from the Library Page, but there were two additional attempts to clear the playlist when resuming playback - these resulted in a segmentation fault.
Despite the description of the problem above, it isn't related to the auto-queuing of the next episode, that presents a differnt test case to teh fix, but not the problem.
To reproduce the original problem, simply interrupt the playback of an episode, and then re-select the same episode. This should trigger a segfault.
After the fix, you should be able to resume or replay an episode regardless of the setting of the auto-queueing and all should work predictibly and intuitively again without crashing.