Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Screenshot portal #140

Closed
cassidyjames opened this issue Aug 23, 2019 · 6 comments · Fixed by elementary/portals#94
Closed

Implement Screenshot portal #140

cassidyjames opened this issue Aug 23, 2019 · 6 comments · Fixed by elementary/portals#94

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented Aug 23, 2019

Looks like it's implemented in xdg-desktop-portal but it's super GNOME-y. We'll want the UI to be effectively the same as the main mode of the app.

@Marukesu
Copy link
Contributor

Marukesu commented Jun 3, 2022

@danrabbit should we drop the screenshot app when implementing the portal? it's already broken in GNOME as reported in #238, since org.gnome.Shell.Screenshot is now an private interface (i don't know about others desktops that use the shell interface besides us and GNOME).

@danirabbit
Copy link
Member

@Marukesu Yeah we should probably implement our own private interface instead of using the org.gnome.Shell.Screenshot namespace, but I'm not sure what you mean about dropping the screenshot app? I think we'd want to implement the portal here in the screenshot app since we have no screenshot UI in gala

@Marukesu
Copy link
Contributor

Marukesu commented Jun 6, 2022

i mean, the portal in interactive mode will be the same of the screenshot app. So instead of having two binaries doing the same thing, have only the portal.

@danirabbit
Copy link
Member

danirabbit commented Jun 6, 2022

@Marukesu ah as in you want to move this interface to https://GitHub.com/elementary/portals?

@Marukesu
Copy link
Contributor

Marukesu commented Jun 6, 2022

We can keep it in this repo, if desired, but what i don't want is having both io.elementary.screenshot and io.elementay.screenshot.xdg-desktop-portal applications when the diference is one exposing an CLI interface and the other an DBus one.

@phase1geo
Copy link

As the developer of Annotator (which includes a feature for taking a screenshot to be edited within the application), it would be nice if the priority of this feature could be bumped up. Looks like it has been opened for a long time now. I have heard in the May release notes that the background portal was going to get some support, but I haven't heard anything about the screenshot portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

4 participants